[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1826439

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>Group: System Environment/Libraries
This tag is not used in Fedora and not in EPEL. Please remove those instead of
hiding them behind %if.

>BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
>Prefix: %{_prefix}
>...
>%install
>[ "${RPM_BUILD_ROOT}" != "/" -a -d ${RPM_BUILD_ROOT} ] && rm -rf ${RPM_BUILD_ROOT}
>...
>%clean
The tags are not used in Fedora; the buildroot should not be deleted at start
of %install.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>ExclusiveArch: x86_64 ppc64le ppc64 aarch64
Add a comment explaining why this is needed.

>%files
>%{_libdir}/%{name}.so
The un-versioned .so typically goes into -devel.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux