[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1827427



--- Comment #7 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
(In reply to Jeremy Newton from comment #4)
> Looks pretty good. I believe the spelling of "dropdown" should be
> "drop-down" as rpmlint suggests, but not a blocker.
> 
Thanks. I normally just copy-paste relevant parts of upstream's README, but
yeah keeping rpmlint quiet on this would make noticing other issues easier, so
I'll do this

> I would query upstream to include a license file though, not a blocker
> though.
Definitely will do

> 
> As well, not a blocker either, but it would be good to include the pull
> request for patch0 url in a comment, possibly with a brief one line
> explanation/summary of the patch.
Ah yes. The URL to the patch is actually there, but I'll put a URL to the pull
request itself and some description. Good call, thanks!

Thanks for the review! Heh, had a mid-air collision just now when trying to
submit this and also assign it to you at the same time.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux