https://bugzilla.redhat.com/show_bug.cgi?id=1828205 David Cantrell <dcantrell@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(dank@xxxxxxxxx) --- Comment #2 from David Cantrell <dcantrell@xxxxxxxxxx> --- Condensed list of items to take care of for review: * Make the package a noarch package with: BuildArch: noarch * Drop '%global debug_package %{nil}' since the noarch thing will take care of that. * In %install, you don't need to install the docs. Just use the %doc macro in %files and reference files in the source dir. They will be installed to %{_docdir}/%{name} * Drop '%docdir' line from %files section. * There is no %changelog section. Everything else checks out. Compliant with packaging policy, has an allowed license, etc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx