https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #32 from David Cantrell <dcantrell@xxxxxxxxxx> --- For completeness, comments on the manual items: (In reply to David Cantrell from comment #31) > [ ]: Package does not contain kernel modules. It does not. > [ ]: Package contains no static executables. It does not. > [ ]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. They are. > Generic: > [ ]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. Apache Linux 2.0, ASL 2.0 noted in License tag. > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "Apache License (v2.0)", "*No > copyright* Apache License (v2.0)". 218 files have unknown license. > Detailed output of licensecheck in > /home/dcantrell/notcurses/licensecheck.txt Apache Linux 2.0, ASL 2.0 noted in License tag. > [ ]: License file installed when any subpackage combination is installed. It is. > [ ]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/notcurses It does. > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/notcurses The -data package should own %{_datadir}/%{name} in %files. It's likely sufficient to just do: %files data %{_datadir}/%{name} And that will pick up the contents of the directory as well as the directory itself. > [ ]: %build honors applicable compiler flags or justifies otherwise. It does. > [ ]: Package contains no bundled libraries without FPC exception. It does not. > [ ]: Changelog in prescribed format. Need to skip a line between changelog entries. > [ ]: Sources contain only permissible code or content. Correct, using the DFSG release tarball for notcurses. > [ ]: Package contains desktop file if it is a GUI application. N/A > [ ]: Development files must be in a -devel package They are. > [ ]: Package uses nothing in %doc for runtime. It does not. > [ ]: Package consistently uses macros (instead of hard-coded directory > names). It does. > [ ]: Package is named according to the Package Naming Guidelines. It is. > [ ]: Package does not generate any conflict. No conflicts. > [ ]: Package obeys FHS, except libexecdir and /usr/target. It does. > [ ]: If the package is a rename of another package, proper Obsoletes and > Provides are present. N/A > [ ]: Requires correct, justified where necessary. They are. > [ ]: Spec file is legible and written in American English. It is. > [ ]: Package contains systemd file(s) if in need. N/A > [ ]: Useful -debuginfo package or justification otherwise. Yes > [ ]: Package is not known to require an ExcludeArch tag. Not required. > [ ]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 143360 bytes in 4 files. Not necessary. > [ ]: Package complies to the Packaging Guidelines That's what this review is doing. > Python: > [ ]: Python eggs must not download any dependencies during the build > process. It does not. > [ ]: A package which is used by another package via an egg interface should > provide egg info. It does. > [ ]: Package meets the Packaging Guidelines::Python Yes. > Generic: > [ ]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. License already included in the source. > [ ]: Final provides and requires are sane (see attachments). They are. > [ ]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > notcurses-data notcurses-data needs: Requires: %{name}%{?_isa} = %{version}-%{release} > [ ]: Package functions as described. It does. > [ ]: Latest version is packaged. It is. > [ ]: Package does not include license text files separate from upstream. It does not. > [ ]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. Yes. > [ ]: Package should compile and build into binary rpms on all supported > architectures. It does. > [ ]: %check is present and all tests pass. N/A > [ ]: Packages should try to preserve timestamps of original installed > files. It does. > Rpmlint > ------- > Checking: notcurses-1.3.3-1.fc33.x86_64.rpm > notcurses-devel-1.3.3-1.fc33.x86_64.rpm > notcurses-static-1.3.3-1.fc33.x86_64.rpm > notcurses-data-1.3.3-1.fc33.noarch.rpm > python3-notcurses-1.3.3-1.fc33.x86_64.rpm > notcurses-debuginfo-1.3.3-1.fc33.x86_64.rpm > notcurses-debugsource-1.3.3-1.fc33.x86_64.rpm > notcurses-1.3.3-1.fc33.src.rpm > notcurses.x86_64: W: shared-lib-calls-exit /usr/lib64/libnotcurses.so.1.3.3 > exit@GLIBC_2.2.5 It does, really? Necessary? > notcurses-static.x86_64: W: no-documentation > notcurses-data.noarch: W: no-documentation Documentation is provided by the main package which these packages require. > python3-notcurses.x86_64: E: non-executable-script > /usr/lib64/python3.8/site-packages/notcurses/notcurses.py 644 > /usr/bin/python3 This again. > Rpmlint (installed packages) > ---------------------------- > notcurses-debugsource.x86_64: W: invalid-url URL: > https://nick-black.com/dankwiki/index.php/Notcurses <urlopen error [Errno > -2] Name or service not known> > notcurses-debuginfo.x86_64: W: invalid-url URL: > https://nick-black.com/dankwiki/index.php/Notcurses <urlopen error [Errno > -2] Name or service not known> > notcurses-devel.x86_64: W: invalid-url URL: > https://nick-black.com/dankwiki/index.php/Notcurses <urlopen error [Errno > -2] Name or service not known> > python3-notcurses.x86_64: W: invalid-url URL: > https://nick-black.com/dankwiki/index.php/Notcurses <urlopen error [Errno > -2] Name or service not known> > notcurses.x86_64: W: invalid-url URL: > https://nick-black.com/dankwiki/index.php/Notcurses <urlopen error [Errno > -2] Name or service not known> > notcurses-data.noarch: W: invalid-url URL: > https://nick-black.com/dankwiki/index.php/Notcurses <urlopen error [Errno > -2] Name or service not known> > notcurses-data.noarch: W: no-documentation > notcurses-static.x86_64: W: invalid-url URL: > https://nick-black.com/dankwiki/index.php/Notcurses <urlopen error [Errno > -2] Name or service not known> > notcurses-static.x86_64: W: no-documentation This is bogus, disregard. URL is valid. > Unversioned so-files > -------------------- > python3-notcurses: /usr/lib64/python3.8/site-packages/_notcurses.abi3.so This again? Summary after this comment. I'm still in the middle of the review, so wait for my condensed summary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
