https://bugzilla.redhat.com/show_bug.cgi?id=1824156 --- Comment #13 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Neal Gompa from comment #10) > > URL: https://github.com/exfat-utils/exfat-utils > > The URL should be "https://github.com/exfatprogs/exfatprogs"; Good point :D > > Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz > > This should be "%{url}/archive/%{version}/%{name}-%{version}.tar.gz" Fixed, I was stuck with the old format. > There's also missing BRs for gcc and make, as those are not guaranteed in > the build root anymore. Added, not cleaning the mock buildroot was not a good idea. > > Requires: libexfat%{?_isa} = %{version}-%{release} > > This self-requires is completely pointless, please remove it > > There's an undefined macro "%{libs}" in the summary. This probably should be > changed to "libextfat". Fixed, leftovers from some other changes. > === Scriptlets === > > "%ldconfig_scriptlets libextfat" is completely unneeded. It does nothing on > Fedora, and this package will not be useful on non-Fedora without the kernel > module being backported first. And if it's getting backported to anything, > it'd be EL8, which *also* does not need this. I actually was planning to build it also for RHEL 7, leaving the option for the user to add DKMS/kmod modules for it. I will add it eventually if needed. Spec URL: https://slaanesh.fedorapeople.org/exfatprogs.spec SRPM URL: https://slaanesh.fedorapeople.org/exfatprogs-1.0.2-1.fc32.src.rpm - Update to 1.0.2. - Added gcc/make build requirements. - Fixed URL and source URL. - Removed useless require on libexfat and macro in libexfat-devel summary. - Removed ldconfig scriptlet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
