[Bug 1827784] Review Request: python-jsonrpc-server - JSON RPC 2.0 server library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1827784



--- Comment #4 from Lumír Balhar <lbalhar@xxxxxxxxxx> ---
Ok, we are almost done here. The last problem I see is that the package is not
installable. The problem comes from setup.py where the dependency on ujson is
defined with the limit "<=1.35" which then leads to automatically generated
"Requires: python3.8dist(ujson) <= 1.35".

However, there is ujson 2.0.0 installed during the build and all tests are
passing so it should work correctly. I've mentioned this fact in
https://github.com/palantir/python-jsonrpc-server/issues/36 From the source
code, it seems, that this module should also work with json module from Python
stdlib (because ujson is disabled on Windows).

You have two possibilities here:
* remove the limit "<=1.35" in setup.py (by sed) and hope that it'll work with
the newer ujson, or
* remove the runtime dependency entirely (from the setup.py and from the
specfile) and let it use json from stdlib

A side-note: Package reviewers use a tool called fedora-review which can do a
lot of testing for you so you might be able to discover a lot of problems
before you open a review request. But you don't have to, of course. I
personally prefer to review my own package before I open a review request
because it can lower the amount of ping-pong :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux