https://bugzilla.redhat.com/show_bug.cgi?id=1820805 Jakub Čajka <jcajka@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jakub Čajka <jcajka@xxxxxxxxxx> --- (In reply to Fabian Affolter from comment #2) > (In reply to Jakub Čajka from comment #1) > > - Package contains bundled copies of libraries. xpc and gioctl under > > MIT/Expat license. It would be good to mention that in comment around > > License tag and add bundled provides > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling. I think > > that those libraries are rather minimal source libraries and it is fine to > > bundle them for time being(when tracked), possibly work with upstream to > > de-bundle them. > > It looks like that the bundled parts are included to fix build issues. I > opened an issue about the unbundling. > > Thanks for adding bringing it up in upstream. I don't want to be overly pedantic, but could you add breakdown in the comment near license section that those libs are under MIT/expat license for the distribution build. Otherwise looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
