Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: phasex - Phase Harmonic Advanced Synthesis EXperiment https://bugzilla.redhat.com/show_bug.cgi?id=334941 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-18 23:07 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMs. + source files match upstream. 27109ee65fe21bac1530518b436aa8b3 phasex-0.11.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + Desktop files installed correctly. + file permissions are appropriate. + gtk-update-icon-cache scriptlets used. + Package phasex-0.11.1-3.fc8 -> Requires: alsa-lib >= 0.9.0 glibc >= 2.3.0 gtk2 >= 2.4.0 jack-audio-connection-kit >= 0.99.0 libX11.so.6 libasound.so.2 libasound.so.2(ALSA_0.9) libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3) libcairo.so.2 libdl.so.2 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libjack.so.0 libm.so.6 libm.so.6(GLIBC_2.0) libpango-1.0.so.0 libpangocairo-1.0.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.3.2) libpthread.so.0(GLIBC_2.3.3) librt.so.1 rtld(GNU_HASH) + GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review