https://bugzilla.redhat.com/show_bug.cgi?id=1825183 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #2 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> --- Ok, quick review: 1. the spec applies official Fedora font templates 2. you do not strictly need the common_description indirection when generating a single font package, but it does no wrong either 4. since we only ship OpenType fonts nowadays, maybe it is not useful to remind the font family format in Summary and description 5. usual rpmlint checking as required in review: $ rpmlint /srv/rpm/fonts-rpm-macros/hanamin-fonts-20170904.fc33.noarch.rpm hanamin-fonts.noarch: W: spelling-error %description -l en_US Hanazono -> Shannon hanamin-fonts.noarch: W: spelling-error %description -l en_US glyphwiki -> glyph wiki, glyph-wiki, hieroglyph hanamin-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/hanamin-fonts/README.txt hanamin-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/hanamin-fonts/THANKS.txt Please fix the wrong-file-end-of-line-encoding,warnings using %linuxtext or any other method Thanks for the conversion APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
