https://bugzilla.redhat.com/show_bug.cgi?id=1818176 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> --- >%{_libdir}/calls/plugins/ofono/libofono.so >%{_libdir}/calls/plugins/ofono/ofono.plugin oFono is currently retired in Fedora and is going through a re-review. If the upstream software allows to omit plugins from a build, for the time being you may hide the oFono plugin behind an %if-%endif. >%{_datadir}/icons/hicolor/scalable/apps/sm.puri.Calls.svg Add "Requires: hicolor-icon-theme". >%{_datadir}/icons/hicolor/symbolic/apps/sm.puri.Calls-symbolic.svg If I'm reading the XDG Icon Theme spec correctly, the icon name has to be an exact match. Please rename the icon during %install to strip the "-symbolic" suffix. https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html >%{_datadir}/metainfo/sm.puri.Calls.appdata.xml You must add "BuildRequires: libappstream-glib" and validate any appdata.xml files installed. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
