https://bugzilla.redhat.com/show_bug.cgi?id=1824156 --- Comment #10 from Neal Gompa <ngompa13@xxxxxxxxx> --- Packaging spec review: === Preamble === > URL: https://github.com/exfat-utils/exfat-utils The URL should be "https://github.com/exfatprogs/exfatprogs"; > Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz This should be "%{url}/archive/%{version}/%{name}-%{version}.tar.gz" There's also missing BRs for gcc and make, as those are not guaranteed in the build root anymore. === libextfat === > Requires: libexfat%{?_isa} = %{version}-%{release} This self-requires is completely pointless, please remove it === libextfat-devel === There's an undefined macro "%{libs}" in the summary. This probably should be changed to "libextfat". === Scriptlets === "%ldconfig_scriptlets libextfat" is completely unneeded. It does nothing on Fedora, and this package will not be useful on non-Fedora without the kernel module being backported first. And if it's getting backported to anything, it'd be EL8, which *also* does not need this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
