[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1826950



--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Spec sanity:

Source0:       
https://files.pythonhosted.org/packages/source/%(n=%{pypi_name}; echo
${n:0:1})/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

Please, use  %pypi_source,
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi


BuildRequires:  python3-tox
BuildRequires:  python3-coverage

There is no %check, why does the package need tox and coverage?



Requires:  python3-django            
Requires:  python3-django-formtools 

The following requirement is generated automatically, please drop the explicit
one:

python3.8dist(django) >= 2.2

The package does not seem to need formtools,
https://github.com/rpkilby/jsonfield/search?q=formtools&unscoped_q=formtools
yields nothing. Please drop the (buil)requires or prove me wrong.



%{python3_sitelib}/* is forbidden (well, discouraged), see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include



* Mon Apr 24 2020 Luis Bazan <lbazan@xxxxxxxxxxxxxxxxx> - 3.1.0-1
- Rebuild  


This entry doesn't make much sense.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux