https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #5 from Neil Horman <nhorman@xxxxxxxxxx> --- Assuming the above are corrected, this is the result of the review: This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [-]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License (v2.0)", "Apache License (v2.0)", "BSD 2-clause "Simplified" License". 159 files have unknown license. Detailed output of licensecheck in /home/nhorman/review/review-rmd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. <= Can't bundle golang libraries with go get [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config(missingok) /usr/bin/scripts %config(missingok) /usr/bin/etc [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [!]: Package obeys FHS, except libexecdir and /usr/target. <= /etc in /usr/bin (see warnings/errors below) [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. (missing BuildRequires for build/run : see above) [x]: Spec file is legible and written in American English. [!]: Package contains systemd file(s) if in need. <= you probably want to add a systemd unit to start rmd [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. <= Not sure why this isn't buildable on non-x86 arches [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [!]: Package complies to the Packaging Guidelines <= golang bundling issues [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://www.example.com/rmd/releases/rmd-1.0.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Package functions as described. <= description in spec file needs to be more verbose [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments <= example.com is not where this package comes from [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint <= Note, all of these warnings/errors need to be fixed ------- Checking: rmd-1.0-1.fc33.x86_64.rpm rmd-debuginfo-1.0-1.fc33.x86_64.rpm rmd-debugsource-1.0-1.fc33.x86_64.rpm rmd-1.0-1.fc33.src.rpm rmd.x86_64: W: description-shorter-than-summary rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/acl/roles/admin/cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/acl/roles/admin/cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/acl/roles/user/user-cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/acl/roles/user/user-cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/acl/url/model.conf rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/acl/url/model.conf rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/acl/url/policy.csv rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/acl/url/policy.csv rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/ca.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/ca.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/key.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/key.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/user-cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/user-cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/user-key.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/user-key.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/server/ca.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/server/ca.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/server/rmd-cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/server/rmd-cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/server/rmd-key.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/server/rmd-key.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cpu_map.toml rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cpu_map.toml rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/pam/rmd rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/pam/rmd rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/pam/test/rmd rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/pam/test/rmd rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/policy.toml rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/policy.toml rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/policy.yaml rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/policy.yaml rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/rmd.toml rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/rmd.toml rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/build-opts-get rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/build-opts-get rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/build.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/build.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/deps.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/deps.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/go-env rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/go-env rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/hacking.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/hacking.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/hacking_v2.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/hacking_v2.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/install.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/install.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/setup_pam_files.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/setup_pam_files.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/setup_rmd_users.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/setup_rmd_users.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/test.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/test.sh rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles/admin rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles/admin/cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/acl/roles/admin/cert.pem 644 rmd.x86_64: W: pem-certificate /usr/bin/etc/rmd/acl/roles/admin/cert.pem rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/acl/roles/admin/cert.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles/user rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles/user/user-cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/acl/roles/user/user-cert.pem 644 rmd.x86_64: W: pem-certificate /usr/bin/etc/rmd/acl/roles/user/user-cert.pem rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/acl/roles/user/user-cert.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/url rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/url/model.conf rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/acl/url/model.conf 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/acl/url/model.conf rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/url/policy.csv rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/acl/url/policy.csv 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/acl/url/policy.csv rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/ca.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/ca.pem 644 rmd.x86_64: W: pem-certificate /usr/bin/etc/rmd/cert/client/ca.pem rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cert/client/ca.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/cert.pem 644 rmd.x86_64: W: pem-certificate /usr/bin/etc/rmd/cert/client/cert.pem rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cert/client/cert.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/key.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/key.pem 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cert/client/key.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/user-cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/user-cert.pem 644 rmd.x86_64: W: pem-certificate /usr/bin/etc/rmd/cert/client/user-cert.pem rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cert/client/user-cert.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/user-key.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/user-key.pem 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cert/client/user-key.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/server rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/server/ca.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/server/ca.pem 644 rmd.x86_64: W: pem-certificate /usr/bin/etc/rmd/cert/server/ca.pem rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cert/server/ca.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/server/rmd-cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/server/rmd-cert.pem 644 rmd.x86_64: W: pem-certificate /usr/bin/etc/rmd/cert/server/rmd-cert.pem rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cert/server/rmd-cert.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/server/rmd-key.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/server/rmd-key.pem 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cert/server/rmd-key.pem rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cpu_map.toml rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cpu_map.toml 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/cpu_map.toml rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/pam rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/pam/rmd rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/pam/rmd 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/pam/rmd rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/pam/test rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/pam/test/rmd rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/pam/test/rmd 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/pam/test/rmd rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/policy.toml rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/policy.toml 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/policy.toml rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/policy.yaml rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/policy.yaml 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/policy.yaml rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/rmd.toml rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/rmd.toml 644 rmd.x86_64: E: script-without-shebang /usr/bin/etc/rmd/rmd.toml rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/build-opts-get rmd.x86_64: W: non-executable-in-bin /usr/bin/scripts/build-opts-get 644 rmd.x86_64: E: script-without-shebang /usr/bin/scripts/build-opts-get rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/build.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/build.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/deps.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/deps.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/go-env rmd.x86_64: W: non-executable-in-bin /usr/bin/scripts/go-env 644 rmd.x86_64: E: script-without-shebang /usr/bin/scripts/go-env rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/hacking.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/hacking.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/hacking_v2.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/hacking_v2.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/install.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/install.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/setup_pam_files.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/setup_pam_files.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/setup_rmd_users.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/setup_rmd_users.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/test.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/test.sh rmd.x86_64: W: no-manual-page-for-binary gen_conf rmd.x86_64: W: no-manual-page-for-binary rmd rmd.x86_64: W: dangerous-command-in-%post rm rmd.x86_64: W: dangerous-command-in-%preun rm rmd.src: W: description-shorter-than-summary rmd.src: W: invalid-url Source0: https://www.example.com/rmd/releases/rmd-1.0.tar.gz HTTP Error 404: Not Found 4 packages and 0 specfiles checked; 67 errors, 90 warnings. Rpmlint (debuginfo) ------------------- Checking: rmd-debuginfo-1.0-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). rmd-debuginfo.x86_64: W: invalid-url URL: https://github.com/intel/rmd <urlopen error [Errno -2] Name or service not known> rmd-debugsource.x86_64: W: invalid-url URL: https://github.com/intel/rmd <urlopen error [Errno -2] Name or service not known> rmd.x86_64: W: description-shorter-than-summary rmd.x86_64: W: invalid-url URL: https://github.com/intel/rmd <urlopen error [Errno -2] Name or service not known> rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/acl/roles/admin/cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/acl/roles/admin/cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/acl/roles/user/user-cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/acl/roles/user/user-cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/acl/url/model.conf rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/acl/url/model.conf rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/acl/url/policy.csv rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/acl/url/policy.csv rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/ca.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/ca.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/key.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/key.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/user-cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/user-cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/client/user-key.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/client/user-key.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/server/ca.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/server/ca.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/server/rmd-cert.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/server/rmd-cert.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cert/server/rmd-key.pem rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cert/server/rmd-key.pem rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/cpu_map.toml rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/cpu_map.toml rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/pam/rmd rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/pam/rmd rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/pam/test/rmd rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/pam/test/rmd rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/policy.toml rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/policy.toml rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/policy.yaml rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/policy.yaml rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/etc/rmd/rmd.toml rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/etc/rmd/rmd.toml rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/build-opts-get rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/build-opts-get rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/build.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/build.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/deps.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/deps.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/go-env rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/go-env rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/hacking.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/hacking.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/hacking_v2.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/hacking_v2.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/install.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/install.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/setup_pam_files.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/setup_pam_files.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/setup_rmd_users.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/setup_rmd_users.sh rmd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/bin/scripts/test.sh rmd.x86_64: W: conffile-without-noreplace-flag /usr/bin/scripts/test.sh rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles/admin rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles/admin/cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/acl/roles/admin/cert.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/acl/roles/admin/cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/acl/roles/admin/cert.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/acl/roles/admin/cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/acl/roles/admin/cert.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles/user rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/roles/user/user-cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/acl/roles/user/user-cert.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/acl/roles/user/user-cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/acl/roles/user/user-cert.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/acl/roles/user/user-cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/acl/roles/user/user-cert.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/url rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/url/model.conf rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/acl/url/model.conf 644 rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/acl/url/policy.csv rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/acl/url/policy.csv 644 rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/ca.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/ca.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/ca.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/ca.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/ca.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/ca.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/cert.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/cert.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/cert.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/key.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/key.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/key.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/key.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/key.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/key.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/user-cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/user-cert.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/user-cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/user-cert.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/user-cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/user-cert.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/client/user-key.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/client/user-key.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/user-key.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/user-key.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/client/user-key.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/client/user-key.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/server rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/server/ca.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/server/ca.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/server/ca.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/server/ca.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/server/ca.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/server/ca.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/server/rmd-cert.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/server/rmd-cert.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/server/rmd-cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/server/rmd-cert.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/server/rmd-cert.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/server/rmd-cert.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cert/server/rmd-key.pem rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cert/server/rmd-key.pem 644 rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/server/rmd-key.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/server/rmd-key.pem' rmd.x86_64: W: read-error /usr/bin/etc/rmd/cert/server/rmd-key.pem [Errno 2] No such file or directory: '/usr/bin/etc/rmd/cert/server/rmd-key.pem' rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/cpu_map.toml rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/cpu_map.toml 644 rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/pam rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/pam/rmd rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/pam/rmd 644 rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/pam/test rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/pam/test/rmd rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/pam/test/rmd 644 rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/policy.toml rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/policy.toml 644 rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/policy.yaml rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/policy.yaml 644 rmd.x86_64: E: subdir-in-bin /usr/bin/etc/rmd/rmd.toml rmd.x86_64: W: non-executable-in-bin /usr/bin/etc/rmd/rmd.toml 644 rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/build-opts-get rmd.x86_64: W: non-executable-in-bin /usr/bin/scripts/build-opts-get 644 rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/build.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/build.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/deps.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/deps.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/go-env rmd.x86_64: W: non-executable-in-bin /usr/bin/scripts/go-env 644 rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/hacking.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/hacking.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/hacking_v2.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/hacking_v2.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/install.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/install.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/setup_pam_files.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/setup_pam_files.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/setup_rmd_users.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/setup_rmd_users.sh rmd.x86_64: E: subdir-in-bin /usr/bin/scripts/test.sh rmd.x86_64: E: executable-marked-as-config-file /usr/bin/scripts/test.sh rmd.x86_64: W: no-manual-page-for-binary gen_conf rmd.x86_64: W: no-manual-page-for-binary rmd rmd.x86_64: W: dangerous-command-in-%post rm rmd.x86_64: W: dangerous-command-in-%preun rm 3 packages and 0 specfiles checked; 47 errors, 104 warnings. Requires -------- rmd (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash config(rmd) libc.so.6()(64bit) libdl.so.2()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) rmd-debuginfo (rpmlib, GLIBC filtered): rmd-debugsource (rpmlib, GLIBC filtered): Provides -------- rmd: config(rmd) rmd rmd(x86-64) rmd-debuginfo: debuginfo(build-id) rmd-debuginfo rmd-debuginfo(x86-64) rmd-debugsource: rmd-debugsource rmd-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -n rmd --mock-options --no-cleanup-after --no-clean --enable-network Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: fonts, Java, Perl, Python, Haskell, R, PHP, Ocaml, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
