https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #16 from Nick Black <dank@xxxxxxxxx> --- > Not sure if these should be versioned like regular shared libraries. Check the Fedora packaging guidelines for Python modules. Taking a step back, I'm having a difficult time imaging a use case that relies on python cffi modules having a particular SONAME, but I'm no Python expert. Taking another step back, setting an SONAME seems a polite thing to do in all cases. Tightening back in, I'm certain I can weave the necessary incantations through to get an SONAME set...but I'm surprised that this isn't already being done by some setuptools layer, or the Fedora Python packaging macros. I've been unable to find firm Fedora guidance yet, save the lint complaint, but surely I'm not the first person to be building a Python cffi module in Fedora, so I'm proceeding under the assumption that the complaint is valid. I'll have this resolved today, one way or the other. > I guess the python_provide macro can be dropped? Done. > %check is not present due to -DUSE_TESTS=off. Another BuildRequire is necessary to enable tests, which I understand is coming in a later package review. Correct. I'll be filing a spec+SRPM for the header-only C++ interface "doctest" > Make it executable unless it shouldn't be. Done (it should be). Thanks for the catch! > Requires: %{name}%{?_isa} = %{version}-%{release} Added. I removed the preexisting line, which lacked the %{?_isa} substitution. Thanks for the catch! > Need clarification on the files in data/. See previous comment and upcoming specfile change. > Recommend adding license information to each source and doc file. Duly noted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
