https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #12 from David Cantrell <dcantrell@xxxxxxxxxx> --- (In reply to Nick Black from comment #10) > nice catch on the cffi, thanks! i've merged your changes, David, and as soon > as I've built and verified new packages, I'll have them staged for you. > > With that said, I'm pretty certain things were working for me before. I can > understand the cffi miss, but I'm surprised your other changes are needed. > Or are they just better idioms? If the latter, thanks for making me aware of > them. If the former, please don't feel compelled to worry about it. If you just build locally using rpmbuild, then things will work fine if you have a build requirement installed but not explicitly stated in the spec file. All Fedora builds are done using mock in clean chroots so the spec file has to contain enough information to set up the build environment from scratch. The Python build macros are preferred over direct calls to setup.py because it will ensure you pick up the Fedora packaging standards for Python stuff and not have to chase that on your own. That said, the Fedora macros also change and you're chasing stuff anyway. But without %py3_build, the install doesn't work right in a mock chroot. I just did a 'mock -r fedora-rawhide-x86_64 --rebuild notcurses-1.3.2-1.fc32.src.rpm' and it worked fine. Continuing the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
