https://bugzilla.redhat.com/show_bug.cgi?id=1807365 --- Comment #11 from Pander <pander@xxxxxxxxxxxxxxxxxxxxx> --- Thanks for packaging, great job! I'm one of the developers. On April 7th, we have releases version 3.1, please see https://github.com/nuspell/nuspell/releases/tag/v3.1.0 and update the package. For your spec file, please make the following changes: 1) add near the top: "Requires: hunspell-en-US" 2) change "Summary: Free and open source C++ spell checking library" into" "Summary: Free and open source C++ spell checking library and command-line tool" 3) change "Nuspell is a free and open source spell checker library. It is designed for languages with rich morphology and complex word compounding. Nuspell is a pure C++ re-implementation of Hunspell." into "Nuspell is a free and open source spell checker library and command-line tool. It is designed for languages with rich morphology and complex word compounding. Nuspell is a pure C++ implementation supporting Hunspell dictionaries." 4) change "%license COPYING COPYING.LESSER" into "%license COPYING.LESSER" because the file COPYING in only related to legacy code which not being used in the build. Some questions from me: 5) Why do you use "-DCMAKE_BUILD_TYPE=Debug"? 6) If you omit "-DBUILD_TESTING=OFF" then you have to add Catch2 as a build dependency See also our Fedora package for 3.1.0 at https://github.com/nuspell/misc-nuspell/blob/master/packaging/rpm/nuspell.spec or contact me if you have any questions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
