[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1824780

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(i.gnatenko.brain@
                   |                            |gmail.com)



--- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Fabio Valentini from comment #1)
> I think you should add "%exclude %{gem_cache}" to the %files section.
> While it's not mentioned in the packaging guidelines, but this is generated
> by gem2rpm, and this is what existing rubygem packages do as well.
> 
> You also need to own "%dir %{gem_instdir}", otherwise that directory is
> unowned.
> 
> Please fix those two issues before importing the package.

↑ I noted this in the review, but apparently Igor didn't see that ...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux