https://bugzilla.redhat.com/show_bug.cgi?id=1821120 Lyes Saadi <fedora@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxx --- Comment #1 from Lyes Saadi <fedora@xxxxxxx> --- Hi ! > Note that fedora-review incorrectly flags the /etc/wlogout/* files as 'not configuration'. They are exactly that - configuration files. No, that's not what it means: > W: foo-package non-conffile-in-etc /etc/xdg/menus/applications-merged/foo-package.menu > > A non-executable file in your package is being installed in /etc, but is not a configuration file. > All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. >From "Common Rpmlint issues": https://fedoraproject.org/wiki/Common_Rpmlint_issues#non-conffile-in-etc You need to change this in your spec file: > %config(noreplace) %{_sysconfdir}/%{name}/layout > %config(noreplace) %{_sysconfdir}/%{name}/style.css (you could keep the %config macro on the whole directory, but it is better not to...) More about that here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files Also, you should just remove the %check section if you have to tests to run... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
