https://bugzilla.redhat.com/show_bug.cgi?id=1823599 Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #6 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- I'm not sure I haven't missed something, but once the issues I've found are fixed, I will check everything again. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text What this means is that you should declare COPYING to be a license file in your %files section (remove it from %doc): %license COPYING - The top entry in the changelog has the wrong date. Working late at night? - I'm not sure what's causing the validation error of the AppData file, when I run it locally there's no error and it's the same in koji and mock. That being said, the specification has changed and the AppData file should be named gjots2.metainfo.xml and placed under /usr/share/metainfo/. Similarly, the <license> tag should now be <metadata_license>. A few tags that would be nice to have are <name>, <release> and <summary>. Also, <updatecontact> should be <update_contact>. - Some more comments in the sections below ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License (v2)", "GPL (v2 or later) (with incorrect FSF address)". 74 files have unknown license. I think that the overall license should be GPLv2, since it is the stricter of the two, or (if you prefer) you could change everything to GPLv2+. See https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F The rpmlint output will help you locate the files that still list the wrong FSF address. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. "Thu Apr 17" should be either "Thu Apr 16" or "Fri Apr 17" [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. There are several instances of British English, please change them to AE. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 389120 bytes in 11 files. You could create a gjots2-doc subpackage, but I don't think it's necessary. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python The following files contain "/usr/bin/env python3" shebang lines: gjots2-3.1.3/bin/gjots2 gjots2-3.1.3/bin/gjots2html.py gjots2-3.1.3/setup.py They should be changed to "/usr/bin/python3" (even though it's done automatically). The same goes for the shebang line in gjots2-3.1.3/uninstall.sh See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes and https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. Why keep the man pages as ISO-8859-1 upstream and not UTF-8? [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gjots2-3.1.3-1.fc33.noarch.rpm gjots2-3.1.3-1.fc33.src.rpm gjots2.noarch: W: spelling-error Summary(en_US) organise -> organist, organism, organize gjots2.noarch: W: spelling-error %description -l en_US gyachts -> yachts, g yachts gjots2.noarch: W: spelling-error %description -l en_US marshall -> Marshall, marshal, marshals gjots2.noarch: W: spelling-error %description -l en_US organise -> organist, organism, organize gjots2.noarch: W: spelling-error %description -l en_US ccrypt -> crypt, c crypt gjots2.noarch: W: spelling-error %description -l en_US gpg -> pg, gig, gag gjots2.noarch: W: spelling-error %description -l en_US openssl -> slope gjots2.noarch: W: invalid-url URL: http://bhepple.freeshell.org/gjots <urlopen error [Errno 111] Connection refused> gjots2.noarch: E: incorrect-fsf-address /usr/bin/docbook2gjots gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2docbook gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2emacs gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2html gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2lpr gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2org gjots2.noarch: E: incorrect-fsf-address /usr/bin/org2gjots gjots2.noarch: W: no-manual-page-for-binary gjots2emacs gjots2.noarch: W: no-manual-page-for-binary gjots2html.py gjots2.noarch: W: no-manual-page-for-binary gjots2lpr gjots2.noarch: W: no-manual-page-for-binary gjots2org gjots2.noarch: W: no-manual-page-for-binary org2gjots gjots2.src: W: spelling-error Summary(en_US) organise -> organist, organism, organize gjots2.src: W: spelling-error %description -l en_US gyachts -> yachts, g yachts gjots2.src: W: spelling-error %description -l en_US marshall -> Marshall, marshal, marshals gjots2.src: W: spelling-error %description -l en_US organise -> organist, organism, organize gjots2.src: W: spelling-error %description -l en_US ccrypt -> crypt, c crypt gjots2.src: W: spelling-error %description -l en_US gpg -> pg, gig, gag gjots2.src: W: spelling-error %description -l en_US openssl -> slope gjots2.src: W: invalid-url URL: http://bhepple.freeshell.org/gjots <urlopen error [Errno 111] Connection refused> gjots2.src:42: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 42) gjots2.src: E: specfile-error warning: bogus date in %changelog: Thu Apr 17 2020 <bob.hepple@xxxxxxxxx> - 3.1.3-1 2 packages and 0 specfiles checked; 8 errors, 22 warnings. Rpmlint (installed packages) ---------------------------- gjots2.noarch: W: spelling-error Summary(en_US) organise -> organist, organism, organize gjots2.noarch: W: spelling-error %description -l en_US gyachts -> yachts, g yachts gjots2.noarch: W: spelling-error %description -l en_US marshall -> Marshall, marshal, marshals gjots2.noarch: W: spelling-error %description -l en_US organise -> organist, organism, organize gjots2.noarch: W: spelling-error %description -l en_US ccrypt -> crypt, c crypt gjots2.noarch: W: spelling-error %description -l en_US gpg -> pg, gig, gag gjots2.noarch: W: spelling-error %description -l en_US openssl -> slope gjots2.noarch: W: invalid-url URL: http://bhepple.freeshell.org/gjots <urlopen error [Errno -2] Name or service not known> gjots2.noarch: E: incorrect-fsf-address /usr/bin/docbook2gjots gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2docbook gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2emacs gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2html gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2lpr gjots2.noarch: E: incorrect-fsf-address /usr/bin/gjots2org gjots2.noarch: E: incorrect-fsf-address /usr/bin/org2gjots gjots2.noarch: W: no-manual-page-for-binary gjots2emacs gjots2.noarch: W: no-manual-page-for-binary gjots2html.py gjots2.noarch: W: no-manual-page-for-binary gjots2lpr gjots2.noarch: W: no-manual-page-for-binary gjots2org gjots2.noarch: W: no-manual-page-for-binary org2gjots gjots2.noarch: E: invalid-appdata-file /usr/share/appdata/gjots2.appdata.xml 1 packages and 0 specfiles checked; 8 errors, 13 warnings. Source checksums ---------------- http://downloads.sourceforge.net/gjots2/gjots2-3.1.3.tgz : CHECKSUM(SHA256) this package : 53cd252a1bda6beadab476ecf8258164436abc87f0bf8c53a3a63ef9afb25ce7 CHECKSUM(SHA256) upstream package : 53cd252a1bda6beadab476ecf8258164436abc87f0bf8c53a3a63ef9afb25ce7 Requires -------- gjots2 (rpmlib, GLIBC filtered): /usr/bin/python3 /usr/bin/sh gtk3 gtksourceview4 python(abi) python3-gobject Provides -------- gjots2: application() application(gjots2.desktop) gjots2 metainfo() metainfo(gjots2.appdata.xml) python3.8dist(gjots2) python3dist(gjots2) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
