https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@xxxxxxxxx --- Comment #9 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- I've been outside of Fedora for quite a while so I might not know what I'm doing here but I think these would be good changes: --- gnucobol.spec.vanilla 2020-04-16 23:44:30.448960249 -0700 +++ gnucobol.spec 2020-04-16 23:45:48.743879632 -0700 @@ -2,7 +2,7 @@ Name: gnucobol Version: 3.0 -Release: 0.rc1%{?dist}.1 +Release: 0.1.rc1%{?dist} Summary: COBOL compiler License: GPLv2+ and LGPLv2+ @@ -63,6 +63,7 @@ %files -f %{name}.lang %license COPYING +%license COPYING.DOC %doc AUTHORS ChangeLog %doc NEWS README THANKS %{_bindir}/cobc @@ -77,15 +78,16 @@ %files -n libcob +%license COPYING.LESSER %{_libdir}/libcob.so.* %{_libdir}/gnucobol/CBL_OC_DUMP.so %post -/sbin/install-info %{_infodir}/open-cobol.info %{_infodir}/dir 2>/dev/null || : +/sbin/install-info %{_infodir}/gnucobol.info %{_infodir}/dir 2>/dev/null || : %postun if [ $1 = 0 ]; then - /sbin/install-info --delete %{_infodir}/open-cobol.info %{_infodir}/dir 2>/dev/null || : + /sbin/install-info --delete %{_infodir}/gnucobol.info %{_infodir}/dir 2>/dev/null || : fi %post -n libcob -p /sbin/ldconfig * Changing Release will let you keep the initial .0 to designate the pre-release and increment the second number no matter how upstream's version or the disttag changes. ie: 0.1.rc1.fc31 0.2.r2.fc31 0.3.r2.fc32 * The %license additions just add the other license files that upstream seems to have added for completeness (with different licenses for different parts of the code) * The install-info changes are because the info filenames have changed. Thanks for packaging this :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
