[Bug 1816301] Review Request: openfoam - computational fluid dynamics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1816301



--- Comment #13 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to david08741 from comment #12)
> (In reply to mark.olesen from comment #11)
> > Currently rebuilding with the various suggested changes, with
> > /usr/lib/openfoam for the common root (instead of /opt).
> 
> I cannot find the relevent guidelines right now, but it would be better if
> you would put header files in /usr/include/openfoam<v>.
> Also, you should probably use %{_libdir} rather then hard-coding /usr/lib/
> so that /usr/lib64 is used on 64bit systems.
> Another reason is
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros

This covers it:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_filesystem_layout

We adhere quite strictly to the Filesystem Hierarchy Standard. So
%{_includedir} is /usr/include, and so on.

> 
> > I would still ideally like to have some more granularity in subpackages,
> > similar to my current section of .deb files.
> > However, I'm not sure if the interdependencies can be properly described in
> > a single .spec file.
> 
> This is no issue. See e.g.
> https://src.fedoraproject.org/rpms/nest/blob/master/f/nest.spec which does
> this.

+1 you can make lots of such dependencies in the spec without any trouble.

> 
> > 
> > The subpackages
> > - myPackage-develop : source code headers and project-specific build scripts.
> 
> Probably should be called myPackage-devel

+1

The relevant guideline is here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux