[Bug 1802370] Review Request: golang-github-francoispqt-gojay - Fastest JSON encoder/decoder with powerful stream API for Golang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1802370

Olivier Lemasle <o.lemasle@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(o.lemasle@gmail.c |
                   |om)                         |



--- Comment #2 from Olivier Lemasle <o.lemasle@xxxxxxxxx> ---
Sorry for the delay, I was waiting to golang-github-viant-toolbox to be
"unbootstrapped", since golang-github-francoispqt-gojay depends on
golang(github.com/viant/toolbox/url), which is not provided by
golang-github-viant-toolbox's bootstrap build.

Finally, I built it myself locally (with its dependencies
golang-github-viant-assertly and golang-github-viant-toolbox unbootstrapped).

Just one thing: is it normal to package the examples directory as %godoc even
in the *binary* package?

golang-github-francoispqt-gojay-1.2.13-1.fc33.x86_64.rpm
/usr/bin/gojay
/usr/lib/.build-id
/usr/lib/.build-id/8b
/usr/lib/.build-id/8b/605f02b9d37b065476634aa3fa482a14edb804
/usr/share/doc/golang-github-francoispqt-gojay
/usr/share/doc/golang-github-francoispqt-gojay/README.md
/usr/share/doc/golang-github-francoispqt-gojay/examples
/usr/share/doc/golang-github-francoispqt-gojay/examples/encode-decode-map
/usr/share/doc/golang-github-francoispqt-gojay/examples/encode-decode-map/main.go
/usr/share/doc/golang-github-francoispqt-gojay/examples/fuzz
/usr/share/doc/golang-github-francoispqt-gojay/examples/fuzz/Makefile
/usr/share/doc/golang-github-francoispqt-gojay/examples/fuzz/main.go
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/Makefile
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/README.md
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/gojay
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/gojay/main.go
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/post.lua
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/standard
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/standard/main.go
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-json
/usr/share/doc/golang-github-francoispqt-gojay/examples/http-json/main.go
/usr/share/doc/golang-github-francoispqt-gojay/examples/websocket
/usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/client
/usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/client/client.go
/usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/comm
/usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/comm/comm.go
/usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/main.go
/usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/server
/usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/server/server.go
/usr/share/licenses/golang-github-francoispqt-gojay
/usr/share/licenses/golang-github-francoispqt-gojay/LICENSE


Otherwise:

- MIT license ok
- Spec + changelog format ok
- Naming guidelines + packaging guidelines ok
- Builds in mock ok

Rpmlint
-------
golang-github-francoispqt-gojay.src: W: spelling-error %description -l en_US
performant -> perform ant, perform-ant, performance
golang-github-francoispqt-gojay.x86_64: W: spelling-error %description -l en_US
performant -> perform ant, perform-ant, performance
golang-github-francoispqt-gojay.x86_64: W: no-manual-page-for-binary gojay
2 packages and 0 specfiles checked; 0 errors, 3 warnings.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux