https://bugzilla.redhat.com/show_bug.cgi?id=1823265 Aleksei Bavshin <alebastr89@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alebastr89@xxxxxxxxx --- Comment #1 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- With the existence of https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/362 and the fact that other distributions are shipping neatvnc separately, I'd suggest creating separate package. Contents of devel package only confirm my point: % rpm -qlp results_wayvnc/0.1.2/1.fc32/wayvnc-devel-0.1.2-1.fc32.x86_64.rpm /usr/include/neatvnc.h /usr/lib64/libneatvnc.so /usr/lib64/pkgconfig/neatvnc.pc For meson it's preferable to convert dependency('x') directly into BuildRequires: pkgconfig(x). Or BuildRequires: cmake(x) for the cases where dependency does not ship .pc file and meson is using cmake to resolve it. I don't see the reason for BR: wlroots-devel, nothing is using wlroots in both sources. You'll need `BuildRequires: pkgconfig(pixman-1)` and `BuildRequires: pkgconfig(libdrm)` instead. I'd also suggest to unbundle miniz but neatvnc upstream already dropped it (https://github.com/any1/neatvnc/commit/b44d1a1f58341ecd78cbdd91eb03865849bcf0a8) so it's fine to wait until the next upstream release. Would be nice to declare that sway >= 1.4 is necessary for wayvnc without making it hard dependency. People may want to use it with wayfire >= 0.4.0 for example. I don't have any good ideas for that except `Requires: wlroots >= 0.10`, which is still not good enough. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
