https://bugzilla.redhat.com/show_bug.cgi?id=1823724 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sgallagh@xxxxxxxxxx --- Comment #3 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #2) > This is weird: > > #%{nodejs_symlink_deps} > > The macro will still expand. Is that intended? The macro happens to be a single line[1], so it will be commented-out, but you're right. This should be `#%%{nodejs_symlink_deps}` for safety. Or removed entirely, of course. I suspect it's there because the standard template for Node packages would use it, but as yarn has no dependencies on other Fedora-packaged Node modules, it's unneeded. [1] ``` %nodejs_sitelib %{_prefix}/lib/node_modules %nodejs_symlink_deps %{_rpmconfigdir}/nodejs-symlink-deps %{nodejs_sitelib} ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
