[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1773719



--- Comment #9 from Brandon Perkins <bperkins@xxxxxxxxxx> ---
(In reply to Ryan O'Hara from comment #7)

> 
> Issues:
> =======
> - Package does not contain duplicates in %files.
>   Note: warning: File listed twice: /usr/share/doc/golang-github-
>   haproxytech-client-native-devel/README.md
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/#_duplicate_files
> 
> - I don't quite understand this because the files aren't really listed in
> the spec file, but rather wee use %gopkgfiles. Also note that this did not
> happen with any of the other Go pacakges we are reviewing as part of the
> haproxy dataplaneapi. This is interesting, though:
> 
> # rpm -q --filesbypkg
> golang-github-haproxytech-client-native-devel-1.2.6-2.fc33.noarch.rpm | grep
> README
> golang-github-haproxytech-client-native-devel
> /usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
> golang-github-haproxytech-client-native-devel
> /usr/share/gocode/src/github.com/haproxytech/client-native/README.md
> golang-github-haproxytech-client-native-devel
> /usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
> 
> 
> # md5sum
> usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
> usr/share/gocode/src/github.com/haproxytech/client-native/README
> usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
> 0a47f2b62cb73f6f84520d404d44f9e2 
> usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
> 0173e68acc6998d347f71ae13122390d 
> usr/share/gocode/src/github.com/haproxytech/client-native/README.md
> 0a47f2b62cb73f6f84520d404d44f9e2 
> usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
> 
> So two of these files are identical, installed in different directories. If
> you look at github.com, you can see this README.md is duplicated in the git
> repo, too. Perhaps the easiest was to fix this is to ask upstream to remove
> one of the files?
> 

Fixed with 1.2.6-3:

[x]: Package does not contain duplicates in %files.

[bperkins@bperkins haproxytech]$ rpm -ql
golang-github-haproxytech-client-native-devel | grep '/README.md$'
/usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
/usr/share/gocode/src/github.com/haproxytech/client-native/README.md

[bperkins@bperkins haproxytech]$ rpm -ql
golang-github-haproxytech-client-native-devel | grep '/README.md$' | xargs -i
md5sum {}
0173e68acc6998d347f71ae13122390d 
/usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
0173e68acc6998d347f71ae13122390d 
/usr/share/gocode/src/github.com/haproxytech/client-native/README.md


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux