https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #7 from Ryan O'Hara <rohara@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/golang-github- haproxytech-client-native-devel/README.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files - I don't quite understand this because the files aren't really listed in the spec file, but rather wee use %gopkgfiles. Also note that this did not happen with any of the other Go pacakges we are reviewing as part of the haproxy dataplaneapi. This is interesting, though: # rpm -q --filesbypkg golang-github-haproxytech-client-native-devel-1.2.6-2.fc33.noarch.rpm | grep README golang-github-haproxytech-client-native-devel /usr/share/doc/golang-github-haproxytech-client-native-devel/README.md golang-github-haproxytech-client-native-devel /usr/share/gocode/src/github.com/haproxytech/client-native/README.md golang-github-haproxytech-client-native-devel /usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md # md5sum usr/share/doc/golang-github-haproxytech-client-native-devel/README.md usr/share/gocode/src/github.com/haproxytech/client-native/README usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md 0a47f2b62cb73f6f84520d404d44f9e2 usr/share/doc/golang-github-haproxytech-client-native-devel/README.md 0173e68acc6998d347f71ae13122390d usr/share/gocode/src/github.com/haproxytech/client-native/README.md 0a47f2b62cb73f6f84520d404d44f9e2 usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md So two of these files are identical, installed in different directories. If you look at github.com, you can see this README.md is duplicated in the git repo, too. Perhaps the easiest was to fix this is to ask upstream to remove one of the files? ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. - ASL 2.0 [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/rohara/1773719-golang-github-haproxytech-client- native/licensecheck.txt - The source contains LICENSE file containig Apache License 2.0. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: - This seems like an issue with all Go modules, as mentioned above. [ ]: %build honors applicable compiler flags or justifies otherwise. - No %build here. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. - All good. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines - All good. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. - No issues above. Latest version is packaged, should be -devel package only (no binaries), and there is no upstream gpg key to use for verify. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-haproxytech-client-native-devel-1.2.6-2.fc33.noarch.rpm golang-github-haproxytech-client-native-1.2.6-2.fc33.src.rpm golang-github-haproxytech-client-native-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/client-native/.goipath golang-github-haproxytech-client-native.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings. - The .goipath hidden files seems to be unavoidable for Go packages. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). golang-github-haproxytech-client-native-devel.noarch: W: invalid-url URL: https://github.com/haproxytech/client-native <urlopen error [Errno -2] Name or service not known> golang-github-haproxytech-client-native-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/client-native/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/haproxytech/client-native/archive/v1.2.6/client-native-1.2.6.tar.gz : CHECKSUM(SHA256) this package : 3ff941f973eeaf6f6089ae961318194f0adda75f9e9b330c060c172aae2ec2a2 CHECKSUM(SHA256) upstream package : 3ff941f973eeaf6f6089ae961318194f0adda75f9e9b330c060c172aae2ec2a2 Requires -------- golang-github-haproxytech-client-native-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/go-openapi/errors) golang(github.com/go-openapi/strfmt) golang(github.com/google/uuid) golang(github.com/haproxytech/config-parser) golang(github.com/haproxytech/config-parser/common) golang(github.com/haproxytech/config-parser/errors) golang(github.com/haproxytech/config-parser/params) golang(github.com/haproxytech/config-parser/parsers/filters) golang(github.com/haproxytech/config-parser/parsers/http/actions) golang(github.com/haproxytech/config-parser/parsers/tcp/actions) golang(github.com/haproxytech/config-parser/types) golang(github.com/haproxytech/models) golang(github.com/mitchellh/mapstructure) golang(github.com/pkg/errors) Provides -------- golang-github-haproxytech-client-native-devel: golang(github.com/haproxytech/client-native) golang(github.com/haproxytech/client-native/configuration) golang(github.com/haproxytech/client-native/misc) golang(github.com/haproxytech/client-native/runtime) golang-github-haproxytech-client-native-devel golang-ipath(github.com/haproxytech/client-native) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -L /home/rohara/tmp/rpms/ -b 1773719 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, R, SugarActivity, fonts, PHP, Haskell, Python, Ocaml, Java, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Built with local dependencies: /home/rohara/tmp/rpms/golang-github-haproxytech-config-parser-devel-1.2.0-1.fc33.noarch.rpm /home/rohara/tmp/rpms/golang-github-haproxytech-models-devel-1.2.4-2.fc33.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
