https://bugzilla.redhat.com/show_bug.cgi?id=1823151 Matthew Miller <mattdm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mattdm@xxxxxxxxxx --- Comment #4 from Matthew Miller <mattdm@xxxxxxxxxx> --- Mightn't it be better to use a proper config file syntax for the persistent settings rather than a bash script? That's really an upstream issue rather than something for package review, though. (Also, along the same lines: thinkpad-tools.service should maybe be `oneshot` rather than `simple`, since it's not a daemon.) I'll file these upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
