Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: phasex - Phase Harmonic Advanced Synthesis EXperiment https://bugzilla.redhat.com/show_bug.cgi?id=334941 ------- Additional Comments From panemade@xxxxxxxxx 2007-10-17 23:42 EST ------- I really don't see any use of installing desktop file twice. I guess there is no use of installing desktop file /usr/share/phasex/phasex.desktop I suggest following patch which will remove extras source1 --- phasex.spec 2007-10-18 09:00:26.000000000 +0530 +++ phasex-modified.spec 2007-10-18 08:59:56.000000000 +0530 @@ -2,14 +2,13 @@ Name: phasex Version: 0.11.1 -Release: 2%{?dist} +Release: 3%{?dist} Summary: PHASEX -- Phase Harmonic Advanced Synthesis EXperiment Group: Applications/Multimedia License: GPLv2 URL: http://sysex.net/phasex/ Source0: http://sysex.net/phasex/%{name}-%{version}.tar.gz -Source1: %{name}.desktop BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: glibc-devel >= 2.3.0 @@ -56,7 +55,10 @@ desktop-file-install --vendor %{desktop_vendor} \ --dir %{buildroot}%{_datadir}/applications \ `for c in ${BASE} ${XTRA} ; do echo "--add-category $c " ; done` \ - %{SOURCE1} + $RPM_BUILD_ROOT%{_datadir}/phasex/%{name}.desktop + +rm $RPM_BUILD_ROOT%{_datadir}/phasex/phasex.desktop + %post touch --no-create %{_datadir}/icons/hicolor || : @@ -87,7 +89,6 @@ %{_datadir}/phasex/pixmaps/* %{_datadir}/phasex/sys-midimaps/* %{_datadir}/phasex/sys-patches/* -%{_datadir}/phasex/phasex.desktop %{_datadir}/applications/%{desktop_vendor}-phasex.desktop %{_datadir}/icons/hicolor/*/apps/phasex-icon.png -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review