https://bugzilla.redhat.com/show_bug.cgi?id=1823151 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Just some comments to get started... - URL field is empty -> https://github.com/devksingh4/thinkpad-tools - Source0 could be %{pypi_source} - The descriptions should end with a period. - LICENSE file must be added to the %files section (%license LICENSE) - /etc/thinkpad-tools-persistence.sh looks misplaced, only configuration files should go under /etc https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files - Systemd unit files: https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#_packaging - Changelog is missing Also, https://github.com/devksingh4/thinkpad-tools/issues/14 should be addressed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
