[Bug 1823134] Review Request: GnuCOBOL - GnuCOBOL is a free implementation of the COBOL programming language.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1823134

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #2 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>%global debug_package %{nil}
This is hardly ever needed. If your rpmbuild is failing due to debuginfo
missing from the executables, then you need to enable debuginfo generation
during build.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages

>Source0:        http://ftp.gnu.org/gnu/gnucobol/gnucobol-2.2.tar.gz
You can use %{version} as part of the URL so you don't have to edit this line
every time.

>./configure --prefix=/usr --libdir=%{_libdir}
You should probably use %configure here. It sets up both --prefix and --libdir
correctly, and will also make sure Fedora's CFLAGS/LDFLAGS are applied (which
will may fix the missing debuginfo issue).

>%files
>%{_includedir}/libcob.h
>%{_includedir}/libcob
>%{_libdir}/libcob.so
>%{_libdir}/libcob.a
These should probably be separated into some -devel or -libs-devel subpackage.

>%{_datadir}/locale/de/LC_MESSAGES/gnucobol.mo                                                                                                                
>%{_datadir}/locale/en@boldquot/LC_MESSAGES/gnucobol.mo                                                                                                       
>%{_datadir}/locale/en@quot/LC_MESSAGES/gnucobol.mo                                                                                                           
>%{_datadir}/locale/es/LC_MESSAGES/gnucobol.mo                                                                                                                
>%{_datadir}/locale/it/LC_MESSAGES/gnucobol.mo                                                                                                                
>%{_datadir}/locale/ja/LC_MESSAGES/gnucobol.mo
>%{_datadir}/locale/nl/LC_MESSAGES/gnucobol.mo
>%{_datadir}/locale/pt/LC_MESSAGES/gnucobol.mo
You can use a wildcard here: "%{_datadir}/locale/**/LC_MESSAGES/gnucobol.mo".

>%{_mandir}/man1/cobc.1.gz
>%{_mandir}/man1/cobcrun.1.gz
Do not assume that man pages will be gzipped. Use a wildcard that can match any
compression method (including no compression at all).
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux