https://bugzilla.redhat.com/show_bug.cgi?id=1822362 --- Comment #7 from Wart <wart@xxxxxxxxxx> --- (In reply to Artur Iwicki from comment #3) > >Group: Applications/System > The "Group:" tag is no longer used in Fedora. > >%clean > The %clean section is no longer used in Fedora. > >%install > >rm -rf $RPM_BUILD_ROOT > Don't do this. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Fixed. > Also, looking at the upstream repo, there's no readily-executable configure > script, but configure.ac. The Makefile is also provided as Makefile.am. > Shouldn't you have "Requires: autoconf" and "Requires: automake" because of > this? These are not present in the upstream git repo (as I would expect), but they are present in the released tarball, which is what this is being built from. So no requirement on autoconf/automake is necessary. New spec: https://fedorapeople.org/~wart/duc.spec New srpm: https://fedorapeople.org/~wart/duc-1.4.4-4.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
