https://bugzilla.redhat.com/show_bug.cgi?id=1821987 --- Comment #9 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Working on the full review... 1. Where does the GPLv2+ come from? Looking at the github page it specifies GPL-2.0 and license file in the source has no reference to "or greater". 2. Minor nit... The desktop file can be improved. Categories=Science;HamRadio;DataVisualization; Hmm... DataVisualization? I would say "Audio"... Not a show stopper by interesting choices by upstream. 3. Thanks for moving the binary, but I'm confused. I thought you were using a shell script to launch it (which is why the binary was renamed to append .bin), but the Desktop file is calling the binary in /usr/libexec... $ cat CubicSDR-0.2.5-3.20200226gitd2f9333.fc33.x86_64.rpm/usr/bin/CubicSDR #!/usr/bin/sh GDK_BACKEND=x11 /usr/libexec/CubicSDR/CubicSDR The desktop file should be using the shell script, which would solve the problem of rpmlint complaining about the use of "env" in the desktop file anyway... Am I missing something? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
