https://bugzilla.redhat.com/show_bug.cgi?id=1818936 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- This is a rebase, restarting the review. Url and Source0 addresses are usable. Ok. Source0 archive (SHA-256: 7689ad5922614094d699c2c3441cb05c7d58cd691779e4f8e79ea456f0f46782) is original. Ok. Summary verified from lib/Mojolicious/Plugin/OpenAPI.pm. Ok. Description verified from lib/Mojolicious/Plugin/OpenAPI.pm. Ok. License verified from Makefile.PL, lib/Mojolicious/Plugin/OpenAPI.pm, README.md. Ok. Other files have other good licenses and are not distributed in any binary package. Ok. No XS code, noarch BuildArch is Ok. FIX: Do not build-require 'perl(YAML::XS)' it's nowhere directly used. TODO: You can remove one of the 'perl(Mojolicious)' BuildRequires. One is enough. TODO: Build-require 'perl(Data::Validate::IP)' for an optional test (t/v2-formats.t:69:). All tests pass. Ok. $ rpmlint perl-Mojolicious-Plugin-OpenAPI.spec ../SRPMS/perl-Mojolicious-Plugin-OpenAPI-3.31-1.fc33.src.rpm ../RPMS/noarch/perl-Mojolicious-Plugin-OpenAPI-3.31-1.fc33.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Mojolicious-Plugin-OpenAPI-3.31-1.fc33.noarch.rpm drwxr-xr-x 2 root root 0 Apr 9 10:41 /usr/share/doc/perl-Mojolicious-Plugin-OpenAPI -rw-r--r-- 1 root root 12342 Mar 31 13:42 /usr/share/doc/perl-Mojolicious-Plugin-OpenAPI/Changes -rw-r--r-- 1 root root 10945 Mar 31 13:42 /usr/share/doc/perl-Mojolicious-Plugin-OpenAPI/README.md -rw-r--r-- 1 root root 3104 Apr 9 10:40 /usr/share/man/man3/JSON::Validator::OpenAPI::Mojolicious.3pm.gz -rw-r--r-- 1 root root 4848 Apr 9 10:40 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI.3pm.gz -rw-r--r-- 1 root root 4053 Apr 9 10:40 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Cors.3pm.gz -rw-r--r-- 1 root root 4334 Apr 9 10:40 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Guides::OpenAPIv2.3pm.gz -rw-r--r-- 1 root root 4908 Apr 9 10:40 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Guides::OpenAPIv3.3pm.gz -rw-r--r-- 1 root root 1915 Apr 9 10:40 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Guides::Swagger2.3pm.gz -rw-r--r-- 1 root root 2712 Apr 9 10:40 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Security.3pm.gz -rw-r--r-- 1 root root 2936 Apr 9 10:40 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::SpecRenderer.3pm.gz drwxr-xr-x 2 root root 0 Apr 9 10:40 /usr/share/perl5/vendor_perl/JSON drwxr-xr-x 2 root root 0 Apr 9 10:40 /usr/share/perl5/vendor_perl/JSON/Validator drwxr-xr-x 2 root root 0 Apr 9 10:40 /usr/share/perl5/vendor_perl/JSON/Validator/OpenAPI -rw-r--r-- 1 root root 20604 Mar 24 02:23 /usr/share/perl5/vendor_perl/JSON/Validator/OpenAPI/Mojolicious.pm drwxr-xr-x 2 root root 0 Apr 9 10:40 /usr/share/perl5/vendor_perl/Mojolicious drwxr-xr-x 2 root root 0 Apr 9 10:40 /usr/share/perl5/vendor_perl/Mojolicious/Plugin drwxr-xr-x 2 root root 0 Apr 9 10:40 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI -rw-r--r-- 1 root root 20868 Mar 31 13:42 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI.pm -rw-r--r-- 1 root root 14203 Mar 6 01:01 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI/Cors.pm drwxr-xr-x 2 root root 0 Apr 9 10:40 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI/Guides -rw-r--r-- 1 root root 8423 Mar 3 07:53 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI/Guides/OpenAPIv2.pod -rw-r--r-- 1 root root 10470 Mar 3 07:53 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI/Guides/OpenAPIv3.pod -rw-r--r-- 1 root root 1782 Mar 3 07:53 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI/Guides/Swagger2.pod -rw-r--r-- 1 root root 6974 Mar 6 01:01 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI/Security.pm -rw-r--r-- 1 root root 34334 Mar 31 13:38 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/OpenAPI/SpecRenderer.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Mojolicious-Plugin-OpenAPI-3.31-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.2) 1 perl(Carp) 1 perl(constant) 1 perl(JSON::Validator) >= 3.16 1 perl(JSON::Validator::OpenAPI::Mojolicious) 1 perl(JSON::Validator::Ref) 1 perl(Mojo::Base) 1 perl(Mojo::JSON) 1 perl(Mojo::Util) 1 perl(Scalar::Util) 1 perl(Time::Local) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Run-require 'perl(Mojolicious::Plugin)' (lib/Mojolicious/Plugin/OpenAPI.pm:2). $ rpm -q --provides -p ../RPMS/noarch/perl-Mojolicious-Plugin-OpenAPI-3.31-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(JSON::Validator::OpenAPI::Mojolicious) 1 perl(Mojolicious::Plugin::OpenAPI) = 3.31 1 perl(Mojolicious::Plugin::OpenAPI::Cors) 1 perl(Mojolicious::Plugin::OpenAPI::Security) 1 perl(Mojolicious::Plugin::OpenAPI::SpecRenderer) 1 perl-Mojolicious-Plugin-OpenAPI = 3.31-1.fc33 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Mojolicious-Plugin-OpenAPI-3.31-1.fc33.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=43155856). Ok. Otherwise the package is in line with Fedora and Perl packaging guile lines. Please correct the 'FIX' items and consider fixing 'TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
