https://bugzilla.redhat.com/show_bug.cgi?id=1821987 --- Comment #6 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Matt Domsch from comment #5) > Thanks for the review notes. > > 1. Its a post-release of 0.2.5, or a pre-release of 0.2.6. I've kept it as > 0.2.5 for this reason. Ok, so where is the 0.2.5 release, when I got to https://cubicsdr.com/ I only see 0.2.4. > 3. Upstream declined to let this be easily separated, or move to tinyxml2, > during the initial review. https://github.com/cjcliffe/CubicSDR/issues/670 So at a high level, I get it, they are prioritizing having a known entity over a distro's responsibility for security. Nothing new. It's not a show stopper for the review but unfortunate. > 6. It's not clear to me if this is required for all systems, or just mine, > due to the graphics card. I've moved this environment setting into the > .desktop file, which works fine, but then you can't start it from the > command line without setting this in your environment. :-( I could use > libexec. That's definitely a concern, but somewhat orthogonal to the (albeit subjecting) requirement. If the purpose of the bash script is to properly load the program, and it is not possible or practical to run the binary directly, then it should get placed in /usr/libexec. This is more of a policy thing than something that has any practical impact. Basically, if an end user can't run the binary directly, it shouldn't be in /usr/bin. After you've updated the spec file, please increment the release (whichever way is more appropriate per #1) and pose a new SPEC and SPRM noting the major changes in the %changelog. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
