https://bugzilla.redhat.com/show_bug.cgi?id=1821523 --- Comment #1 from Harald Hoyer <harald@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed HH: Note by package reviewer Harald Hoyer <harald@xxxxxxxxxx> Issues: ======= - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: musl-devel, musl-libc-static. Does not provide -static: musl-devel. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries HH: The '*.a' contained in musl-devel are library stubs not containing any code. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [-!x]: Package contains no static executables. HH: musl-libc contains /lib64/ld-musl-x86_64.so.1, which is necessarily statically linked [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "BSD 2-clause "Simplified" License", "ISC License", "Public domain", "BSD 3-clause "New" or "Revised" License". HH: Detailed information about other licenses is given in the Copyright file. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/rpm, /usr/x86_64-linux-musl/lib64, /usr/lib/rpm/macros.d, /usr/x86_64-linux-musl/include, /usr/x86_64-linux-musl [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. HH: No s390 support (but s390x) [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in musl- libc , musl-filesystem , musl-devel , musl-libc-static , musl-gcc , musl-clang [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: musl-libc-1.2.0-1.fc33.x86_64.rpm musl-filesystem-1.2.0-1.fc33.x86_64.rpm musl-devel-1.2.0-1.fc33.x86_64.rpm musl-libc-static-1.2.0-1.fc33.x86_64.rpm musl-gcc-1.2.0-1.fc33.x86_64.rpm musl-clang-1.2.0-1.fc33.x86_64.rpm musl-debugsource-1.2.0-1.fc33.x86_64.rpm musl-1.2.0-1.fc33.src.rpm [HH: OK] musl-libc.x86_64: E: shared-lib-without-dependency-information /lib/ld-musl-x86_64.so.1 [HH: OK] musl-libc.x86_64: W: no-documentation [HH: OK] musl-filesystem.x86_64: W: no-documentation [HH: OK] musl-filesystem.x86_64: W: non-standard-dir-in-usr x86_64-linux-musl [HH: OK] musl-devel.x86_64: W: no-dependency-on musl/musl-libs/libmusl [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libcrypt.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libdl.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libm.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libpthread.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libresolv.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/librt.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libutil.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libxnet.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: only-non-binary-in-usr-lib [HH: OK] musl-devel.x86_64: E: zero-length /usr/lib/rpm/macros.d/macros.musl [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/hwcap.h [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/ioctl_fix.h [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/poll.h [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/resource.h [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/socket.h [HH: OK] musl-devel.x86_64: W: non-standard-dir-in-usr x86_64-linux-musl [HH: OK] musl-libc-static.x86_64: W: no-documentation [HH: OK] musl-libc-static.x86_64: W: non-standard-dir-in-usr x86_64-linux-musl [HH: OK] musl-gcc.x86_64: E: devel-dependency musl-devel [HH: OK] musl-gcc.x86_64: W: no-documentation [HH: OK] musl-gcc.x86_64: W: no-manual-page-for-binary musl-gcc [HH: OK] musl-gcc.x86_64: W: non-standard-dir-in-usr x86_64-linux-musl [HH: OK] musl-clang.x86_64: E: devel-dependency musl-devel [HH: OK] musl-clang.x86_64: W: no-documentation [HH: OK] musl-clang.x86_64: W: no-manual-page-for-binary ld.musl-clang [HH: OK] musl-clang.x86_64: W: no-manual-page-for-binary musl-clang [HH: OK] musl.src:62: E: hardcoded-library-path in %{_prefix}/lib/%{_musl_platform} [HH: OK] musl.src:76: E: hardcoded-library-path in /lib [HH: OK] musl.src:234: E: hardcoded-library-path in %{buildroot}/lib/ld-musl-%{_musl_target_cpu}.so.1 [HH: OK] musl.src:235: E: hardcoded-library-path in %{buildroot}/lib/ld-musl-%{_musl_target_cpu}.so.1 [HH: OK] musl.src:236: E: hardcoded-library-path in %{buildroot}/lib/ld-musl-%{_musl_target_cpu}.so.1 [HH: OK] musl.src:249: E: hardcoded-library-path in %{buildroot}/lib/ld-musl-%{_musl_target_cpu}.so.1 [HH: OK] musl.src:261: E: hardcoded-library-path in /lib/ld-musl-%{_musl_target_cpu}.so.1 musl.src:187: W: mixed-use-of-spaces-and-tabs (spaces: line 187, tab: line 79) 8 packages and 0 specfiles checked; 16 errors, 23 warnings. Rpmlint (debuginfo) ------------------- Checking: musl-libc-debuginfo-1.2.0-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "de_DE.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "de_DE.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). HH: URL OK, somehow failed to get network connection [HH: OK] musl-libc-static.x86_64: W: invalid-url URL: https://musl.libc.org <urlopen error [Errno -2] Name or service not known> [HH: OK] musl-libc-static.x86_64: W: no-documentation [HH: OK] musl-libc-static.x86_64: W: non-standard-dir-in-usr x86_64-linux-musl [HH: OK] musl-clang.x86_64: E: devel-dependency musl-devel [HH: OK] musl-clang.x86_64: W: invalid-url URL: https://musl.libc.org <urlopen error [Errno -2] Name or service not known> [HH: OK] musl-clang.x86_64: W: no-documentation [HH: OK] musl-clang.x86_64: W: no-manual-page-for-binary ld.musl-clang [HH: OK] musl-clang.x86_64: W: no-manual-page-for-binary musl-clang [HH: OK] musl-libc-debuginfo.x86_64: W: invalid-url URL: https://musl.libc.org <urlopen error [Errno -2] Name or service not known> [HH: OK] musl-debugsource.x86_64: W: invalid-url URL: https://musl.libc.org <urlopen error [Errno -2] Name or service not known> [HH: OK] musl-gcc.x86_64: E: devel-dependency musl-devel [HH: OK] musl-gcc.x86_64: W: invalid-url URL: https://musl.libc.org <urlopen error [Errno -2] Name or service not known> [HH: OK] musl-gcc.x86_64: W: no-documentation [HH: OK] musl-gcc.x86_64: W: no-manual-page-for-binary musl-gcc [HH: OK] musl-gcc.x86_64: W: non-standard-dir-in-usr x86_64-linux-musl [HH: OK] musl-libc.x86_64: W: invalid-url URL: https://musl.libc.org <urlopen error [Errno -2] Name or service not known> [HH: OK] musl-libc.x86_64: E: shared-lib-without-dependency-information /lib/ld-musl-x86_64.so.1 [HH: OK] musl-libc.x86_64: W: no-documentation [HH: OK] musl-filesystem.x86_64: W: invalid-url URL: https://musl.libc.org <urlopen error [Errno -2] Name or service not known> [HH: OK] musl-filesystem.x86_64: W: no-documentation [HH: OK] musl-filesystem.x86_64: W: non-standard-dir-in-usr x86_64-linux-musl [HH: OK] musl-devel.x86_64: W: no-dependency-on musl/musl-libs/libmusl [HH: OK] musl-devel.x86_64: W: invalid-url URL: https://musl.libc.org <urlopen error [Errno -2] Name or service not known> HH: stub libraries [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libcrypt.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libdl.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libm.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libpthread.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libresolv.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/librt.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libutil.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: binaryinfo-tail-failed /usr/x86_64-linux-musl/lib64/libxnet.a: [Errno 22] Invalid argument [HH: OK] musl-devel.x86_64: W: only-non-binary-in-usr-lib musl-devel.x86_64: E: zero-length /usr/lib/rpm/macros.d/macros.musl [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/hwcap.h [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/ioctl_fix.h [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/poll.h [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/resource.h [HH: OK] musl-devel.x86_64: E: zero-length /usr/x86_64-linux-musl/include/bits/socket.h [HH: OK] musl-devel.x86_64: W: non-standard-dir-in-usr x86_64-linux-musl 8 packages and 0 specfiles checked; 9 errors, 30 warnings. Source checksums ---------------- https://musl.libc.org/musl.pub : CHECKSUM(SHA256) this package : bf6baaa63c2c4958636850a24bb9d2d514c8b6a1b3ab9c08f3b75910fb6f57be CHECKSUM(SHA256) upstream package : bf6baaa63c2c4958636850a24bb9d2d514c8b6a1b3ab9c08f3b75910fb6f57be https://musl.libc.org/releases/musl-1.2.0.tar.gz.asc : CHECKSUM(SHA256) this package : 5887eefa25cc4dc9868d038c136390db45c9528b84af343a5327b43d6d63fe44 CHECKSUM(SHA256) upstream package : 5887eefa25cc4dc9868d038c136390db45c9528b84af343a5327b43d6d63fe44 https://musl.libc.org/releases/musl-1.2.0.tar.gz : CHECKSUM(SHA256) this package : c6de7b191139142d3f9a7b5b702c9cae1b5ee6e7f57e582da9328629408fd4e8 CHECKSUM(SHA256) upstream package : c6de7b191139142d3f9a7b5b702c9cae1b5ee6e7f57e582da9328629408fd4e8 Requires -------- musl-libc (rpmlib, GLIBC filtered): config(musl-libc) musl-filesystem(x86-64) musl-filesystem (rpmlib, GLIBC filtered): musl-devel (rpmlib, GLIBC filtered): ld-musl-x86_64.so.1()(64bit) musl-libc musl-libc-static (rpmlib, GLIBC filtered): musl-devel(x86-64) musl-gcc (rpmlib, GLIBC filtered): /usr/bin/sh gcc musl-devel musl-clang (rpmlib, GLIBC filtered): /usr/bin/sh clang musl-devel musl-debugsource (rpmlib, GLIBC filtered): Provides -------- musl-libc: config(musl-libc) ld-musl-x86_64.so.1()(64bit) musl-libc musl-libc(x86-64) musl-libs musl-libs(x86-64) musl-filesystem: musl-filesystem musl-filesystem(x86-64) musl-devel: musl-devel musl-devel(x86-64) musl-headers musl-headers(x86-64) musl-libc-static: musl-libc-static musl-libc-static(x86-64) musl-static musl-static(x86-64) musl-gcc: musl-gcc musl-gcc(x86-64) musl-clang: musl-clang musl-clang(x86-64) musl-debugsource: musl-debugsource musl-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1821523 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Python, SugarActivity, Haskell, fonts, Perl, Java, R, Ocaml, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
