Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-device-manager - Graphical Device Manager Application https://bugzilla.redhat.com/show_bug.cgi?id=335641 ------- Additional Comments From mclasen@xxxxxxxxxx 2007-10-17 15:48 EST ------- Ok, I've done Parag and a few of my own cleanup to the spec, and I'll base the review on that cleaned up spec/srpm, which I'll attach below. rpmlint output: rpmlint /var/lib/mock/fedora-development-i386/result/gnome-device-manager-*.i386.rpm gnome-device-manager-devel.i386: W: no-documentation gnome-device-manager-libs.i386: W: no-documentation Package name: ok spec file name: ok packaging guidelines: followed license: ok license field: ok license file: ok spec language: american english readability: excellent upstream sources: ok buildable: yes ExcludeArch: n/a BRs: ok locales: handled properly shared libs: ok relocatable: n/a directory ownership: ok %files: ok permissions: ok %clean: ok macro use: consistent content: permissible large docs: n/a headers: ok static libs: n/a pc files: ok shared libs: ok devel package: ok libtool archives: ok directory ownership: ok %install: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review