[Bug 1820391] Review Request: RediSearch - full-text search over Redis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1820391



--- Comment #4 from Nathan Scott <nathans@xxxxxxxxxx> ---
(In reply to Andreas Gerstmayr from comment #3)
> (In reply to Nathan Scott from comment #2)
> > That is the latest release with a non-open-source license. :(
> 
> Hmm, that's quite unfortunate - so we'll be stuck on an outdated version
> forever if no volunteers are working on the open source fork :/

Indeed.  Fortunately it was a fairly mature version they forked from,
with good automated testing in place, and the sorts of features they're
now adding have tended to be scaling (clustering) related - not super
important for our immediate needs (and those of many other folk).

It is what it is.

> > [!]: Sources can be downloaded from URI in Source: tag
> >     Note: Could not download Source0:
> >     https://github.com/GoodFORM/RediSearch/archive/1.2.2/RediSearch-1.2.2.tar.gz
> >     See: https://docs.fedoraproject.org/en-US/packaging-
> >     guidelines/SourceURL/
> 
> The git tag is prefixed with "v", which is missing in the URL.

Ah - thanks, fixed.

> > Unversioned so-files
> > --------------------
> > RediSearch: /usr/lib64/redis/modules/redisearch.so
> 
> I guess this is not a problem, as no other binary is linking to it and redis

Yep, and its not visible to ldconfig in the Fedora location
(so no ldd search path will 'accidentally' find it)

> Package approved when the URL issue is fixed.

Thanks for the review!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux