[Bug 1807753] Review Request: ydotool - Generic command-line automation tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1807753



--- Comment #11 from Artem <ego.cordatus@xxxxxxxxx> ---
### Still recommended to do #3:

3. Add pushd/popd and & '%make_build -C %{_target_platform}' macros in %build
stage. This is important and Cmake warn even during build:

  "this warning will become a fatal error in future CMake releases."

  Code block:
  ```
  %prep
  %autosetup -n %{name}-%{commit}
  mkdir -p %{_target_platform}

  %build
  pushd %{_target_platform}
  %cmake ..
  popd
  %make_build -C %{_target_platform}

  %install
  %make_install -C %{_target_platform}
  ```


### And remove

  %{_exec_prefix}/lib/systemd/

from %files section.

- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/lib/systemd/system/ydotool.service
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files


### Also add zero in current date. Use 'rpmdev-bumpspec' for changelogs:

  * Tue Apr 01 2020 Bob Hepple <bob.hepple@xxxxxxxxx> -
0.1.9-0.1.20200401git.9c3a4e7

W: incoherent-version-in-changelog 0.1.9-0.1.20200401git.9c3a4e7
['0.1.9-0.1.20200401.git.9c3a4e7.fc33', '0.1.9-0.1.20200401.git.9c3a4e7']


### And there was errors:

  W: shared-lib-calls-exit /usr/lib64/libydotool.so.0.1.9 exit@GLIBC_2.2.5
  E: postin-without-ldconfig /usr/lib64/libydotool.so.0.1.9
  E: postun-without-ldconfig /usr/lib64/libydotool.so.0.1.9


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux