https://bugzilla.redhat.com/show_bug.cgi?id=1819148 --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Weiping from comment #1) > Hi, > > this is an informal review: Hello Weiping. Thanks for doing this. > > Name: act > > %global lname AutomaticComponentToolkit > It's not recommended to use lname, please follow name guideline: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ I don't understand. There is not a single mention of lname in that guidelines. Nor it is said that it is not recommended. The simple fact that it is not mentioned doesn't mean we should not do this. > > %{?gometa} > > %{?!gometa:BuildRequires: /usr/bin/go} > Packages MUST have BuildRequires: go-rpm-macros. > https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ > #_dependencies On Fedora, %gometa adds that. On EPEL 7, there is no go-rpm-macros :( > > mkdir -p %{buildroot}%{_bindir} > > install -m 0755 -vp act %{buildroot}%{_bindir}/ > > Better to use these macors: > install -m 0755 -vd %{buildroot}%{_bindir} > install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ > https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ > #_binary_package_installation I found that overcomplicated and I don't have %{gobuilddir} on EPEL 7. > Please add > %global golicenses LICENSE.md > %global godocs README.md > > > > There is an example, for simple binary package: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ > #_simple_binary_package It is, but since I don't have the devel subpackage, I think this would only make the spec more complicated. > fedora-review failed to build this package: > + GO111MODULE=off > + go build -buildmode pie -compiler gc '-tags=rpm_crashtraceback ' -ldflags > ' -B 0x4b072daa5c63e7865a65639d9d94578a8d195116 -extldflags '\''-Wl,-z,relro > -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld > '\''' -a -v -x -o act Source/actutils.go Source/automaticcomponenttoolkit.go > Source/buildbindingccpp.go Source/buildbindingcsharp.go > Source/buildbindinggo.go Source/buildbindingnode.go > Source/buildbindingpascal.go Source/buildbindingpython.go > Source/buildimplementationcpp.go Source/buildimplementationpascal.go > Source/componentdefinition.go Source/componentdiff.go Source/languagec.go > Source/languagecpp.go Source/languagepascal.go Source/languagewriter.go > WORK=/tmp/go-build362236170 > runtime: mlock of signal stack failed: 12 > runtime: increase the mlock limit (ulimit -l) or > runtime: update your kernel to 5.3.15+, 5.4.2+, or 5.5+ > fatal error: mlock failed > runtime stack: > runtime.throw(0xa3b43e, 0xc) > /usr/lib/golang/src/runtime/panic.go:1112 +0x72 I can build the package just fine, see the copr builds. How are you using fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
