https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #6 from Jens Petersen <petersen@xxxxxxxxxx> --- Thank you, Zbigniew, sorry for the delay. I think I have fixed all the issues you pointed out: (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > > URL: http://www.gnu.org/software/hello/ > > https please. Even GNU supports that nowadays. :-) > make %{?_smp_mflags} → %make_build > make install DESTDIR=$RPM_BUILD_ROOT → %make_install (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > $RPM_BUILD_ROOT → %buildroot to make things more modern. Done (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > Note: License file COPYING is not marked as %license Oops, good catch > Also: Requires: info seems suspicious. How about Recommends? https://src.fedoraproject.org/fork/petersen/rpms/hello/c/1317b3590753f0eea349c0a266fb51fa4a5e0d70 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
