Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blitz : C++ class library for matrix scientific computing https://bugzilla.redhat.com/show_bug.cgi?id=246432 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-17 06:11 EST ------- thanks. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 031df2816c73e2d3bd6d667bbac19eca blitz-0.9.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + blitz.pc files are present. + -devel,-docs subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig and install-info scriptlets are used. + package blitz-0.9-3.fc8 -> Provides: libblitz.so.0 Requires: libblitz.so.0 libc.so.6 libc.so.6(GLIBC_2.1.3) libgcc_s.so.1 libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) + package blitz-devel-0.9-3.fc8 -> Requires: blitz = 0.9-3.fc8 libblitz.so.0 pkgconfig + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review