https://bugzilla.redhat.com/show_bug.cgi?id=1807753 --- Comment #9 from Artem <ego.cordatus@xxxxxxxxx> --- Created attachment 1675094 --> https://bugzilla.redhat.com/attachment.cgi?id=1675094&action=edit Spec file patch 1. Drop '%global __strip /bin/strip' This handled automatically during build. 2. Replace tabs in description where listing features with '-` char for example: Currently implemented command(s): type - Type a string key - Press keys mousemove - Move mouse pointer to absolute position mousemove_relative - Move mouse pointer to relative position mouseup - Generate mouse up event mousedown - Generate mouse down event click - Click on mouse buttons recorder - Record/replay input events -> Currently implemented command(s): - type - Type a string - key - Press keys - mousemove - Move mouse pointer to absolute position - mousemove_relative - Move mouse pointer to relative position - mouseup - Generate mouse up event - mousedown - Generate mouse down event - click - Click on mouse buttons - recorder - Record/replay input events 3. Add pushd/popd and & '%make_build -C %{_target_platform}' macros in %build stage. This is important and Cmake warn even during build: "this warning will become a fatal error in future CMake releases." 4. Use consistenly macroses in %files section: %{_includedir}/ydotool/ -> %{_includedir}/%{name}/ 5. Add .patch extension to your patch file. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /usr/lib/systemd Add: %{?systemd_requires} to Requires. See attached patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
