https://bugzilla.redhat.com/show_bug.cgi?id=1795360 --- Comment #4 from Chris Adams <linux@xxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #3) > - That's not how you add a Patch: Yeah, sorry, that was a quick/dirty way to keep active things in %build. I've moved it. I also conditionalized the gnulib update and gnulib-devel dependency; the RPM isn't in EPEL6, but I found that the bundled version builds okay there. Please let me know if that looks okay to you (it builds okay for me on Fedora 31/32/rawhide and EPEL6/7/8). > - Provides: bundled(gnulib) in place as required. > Note: Bundled gnulib but no Provides: bundled(gnulib) Oops, missed that. I wasn't thinking about it being bundled (since I'm updating it). > - License is not good: the lib part is under GPLv3+ and src/mustach.* under > ASL 2.0. Please add them to the License: field and add a comment explaning > the license breakdown. Yeah, I just checked the main license, didn't inspect. Updated. > - Convert this file to UTF-8: > > dhcpd-pools.x86_64: W: file-not-utf8 /usr/share/doc/dhcpd-pools/THANKS Ah, that was something I hadn't done before. Fixed. New upload: Spec URL: https://cmadams.fedorapeople.org/dhcpd-pools/dhcpd-pools.spec SRPM URL: https://cmadams.fedorapeople.org/dhcpd-pools/dhcpd-pools-3.0-3.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
