https://bugzilla.redhat.com/show_bug.cgi?id=1816858 --- Comment #7 from Cole Robinson <crobinso@xxxxxxxxxx> --- (In reply to Christophe de Dinechin from comment #5) > Reviewed the spec file rapidly. Looks good to me with two notes: > > 1) Do we need the -Sgit option for autosetup? > If using git format-patch output for .patch files in the repo, using -Sgit can be required in some instances IIRC, but I don't remember the details. We can probably get away with out it, it's just what I use by default. > 2) I would use the same DESTDIR for both make and make install. Often, > makefiles introduce hard-to-debug dependencies on make variables, we don't > want some mysterious failure down the line. Good point, I will add that before committing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
