https://bugzilla.redhat.com/show_bug.cgi?id=1816858 Fabiano Fidêncio <fidencio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(crobinso@redhat.c | |om) --- Comment #2 from Fabiano Fidêncio <fidencio@xxxxxxxxxx> --- Cole, Before actually going through the tedious official review process, there's one thing that caught my attention. Here's the output of the unpacked RPM: > fidencio@dahmer /tmp/1816858-kata-agent/rpms-unpacked $ ls -lhaR * > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm: > total 0 > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > drwxrwxr-x. 5 fidencio fidencio 100 Mar 25 06:42 usr > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr: > total 0 > drwxrwxr-x. 5 fidencio fidencio 100 Mar 25 06:42 . > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 lib > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 libexec > drwxrwxr-x. 4 fidencio fidencio 80 Mar 25 06:42 share > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/lib: > total 0 > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxrwxr-x. 5 fidencio fidencio 100 Mar 25 06:42 .. > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 .build-id > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/lib/.build-id: > total 0 > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > drwxr-xr-x. 2 fidencio fidencio 60 Mar 25 06:42 df > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/lib/.build-id/df: > total 0 > drwxr-xr-x. 2 fidencio fidencio 60 Mar 25 06:42 . > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > lrwxrwxrwx. 1 fidencio fidencio 64 Mar 25 06:42 8eb6fe32584f97fb0f462e500f07819fd5ac83 -> ../../../../usr/libexec/kata-containers/agent/usr/bin/kata-agent > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/libexec: > total 0 > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxrwxr-x. 5 fidencio fidencio 100 Mar 25 06:42 .. > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 kata-containers > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/libexec/kata-containers: > total 0 > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 agent Eveyrthing is fine until here ... > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/libexec/kata-containers/agent: > total 0 > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > drwxr-xr-x. 4 fidencio fidencio 80 Mar 25 06:42 usr > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/libexec/kata-containers/agent/usr: > total 0 > drwxr-xr-x. 4 fidencio fidencio 80 Mar 25 06:42 . > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > drwxr-xr-x. 2 fidencio fidencio 60 Mar 25 06:42 bin > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 lib > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/libexec/kata-containers/agent/usr/bin: > total 26M > drwxr-xr-x. 2 fidencio fidencio 60 Mar 25 06:42 . > drwxr-xr-x. 4 fidencio fidencio 80 Mar 25 06:42 .. > -rwxr-xr-x. 1 fidencio fidencio 26M Mar 25 06:38 kata-agent I'd rather place the kata-agent binary together with kata-netmonm, kata-proxy, and kata-shim, in /usr/libexec/kata-containers > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/libexec/kata-containers/agent/usr/lib: > total 0 > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxr-xr-x. 4 fidencio fidencio 80 Mar 25 06:42 .. > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 systemd > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/libexec/kata-containers/agent/usr/lib/systemd: > total 0 > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > drwxr-xr-x. 2 fidencio fidencio 80 Mar 25 06:42 system > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/libexec/kata-containers/agent/usr/lib/systemd/system: > total 8.0K > drwxr-xr-x. 2 fidencio fidencio 80 Mar 25 06:42 . > drwxr-xr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > -rw-r--r--. 1 fidencio fidencio 582 Mar 25 06:38 kata-agent.service > -rw-r--r--. 1 fidencio fidencio 332 Mar 25 06:38 kata-containers.target For the systemd files, I'd rather place them in /usr/libexec/kata-containers/agent/systemd/ > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/share: > total 0 > drwxrwxr-x. 4 fidencio fidencio 80 Mar 25 06:42 . > drwxrwxr-x. 5 fidencio fidencio 100 Mar 25 06:42 .. > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 doc > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 licenses > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/share/doc: > total 0 > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxrwxr-x. 4 fidencio fidencio 80 Mar 25 06:42 .. > drwxr-xr-x. 2 fidencio fidencio 100 Mar 25 06:42 kata-agent > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/share/doc/kata-agent: > total 16K > drwxr-xr-x. 2 fidencio fidencio 100 Mar 25 06:42 . > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > -rw-r--r--. 1 fidencio fidencio 170 Mar 17 20:09 CODE_OF_CONDUCT.md > -rw-r--r--. 1 fidencio fidencio 184 Mar 17 20:09 CONTRIBUTING.md > -rw-r--r--. 1 fidencio fidencio 4.8K Mar 17 20:09 README.md > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/share/licenses: > total 0 > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 . > drwxrwxr-x. 4 fidencio fidencio 80 Mar 25 06:42 .. > drwxr-xr-x. 2 fidencio fidencio 60 Mar 25 06:42 kata-agent > > kata-agent-1.11.0-0.1.alpha1.fc33.x86_64.rpm/usr/share/licenses/kata-agent: > total 12K > drwxr-xr-x. 2 fidencio fidencio 60 Mar 25 06:42 . > drwxrwxr-x. 3 fidencio fidencio 60 Mar 25 06:42 .. > -rw-r--r--. 1 fidencio fidencio 12K Mar 17 20:09 LICENSE Everything else is fine. So, comments made, may I ask your take on those? Is there some specific reason behind the dir structure chosen for kata-agent binary and systemd files? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
