Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xgrav - A simple physics simulation for a large number of particles https://bugzilla.redhat.com/show_bug.cgi?id=333921 ------- Additional Comments From pertusus@xxxxxxx 2007-10-16 17:01 EST ------- The %build section is a bit broken. There are 2 make invocations and LINUX_LDFLAGS is not used. I think that it should be: make LINUX_CFLAGS="-c $RPM_OPT_FLAGS `pkg-config --cflags sdl` -DWITH_ROOTWINDOW" LINUX_LDFLAGS="$RPM_OPT_FLAGS `pkg-config --libs sdl` -lGL `pkg-config --libs x11` -lm" All on one line. I don't remember if putting the variables in the environment works, I think it doesn't. The timestamp for the source file isn't kept. You can use wget -N or spectool -g or similar curl option. Quite strangely, the stamp is only 4 seconds different from upstream... Source match upstream: 2214b0591ced40f27e00accdb8fa8f41 xgrav-1.2.0.tgz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review