https://bugzilla.redhat.com/show_bug.cgi?id=1811177 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - You seem to be confused about how conditionals work, please read https://rpm.org/user_doc/conditional_builds.html %bcond_with disables something by default whereas %bcond_without enables something by default. So write: %bcond_without check so enable checks. - Bump to 0.0.3 - There's a test error due to a change in *Go 1.14*, now URL are between quotes. Report it upstream and patch it locally with sed in %prep for now. --- FAIL: Test_doaction (0.00s) credential_test.go:182: Error Trace: credential_test.go:182 Error: Not equal: expected: "parse # #%gfdf: invalid URL escape \"%gf\"" actual : "parse \"# #%gfdf\": invalid URL escape \"%gf\"" Diff: --- Expected +++ Actual @@ -1 +1 @@ -parse # #%gfdf: invalid URL escape "%gf" +parse "# #%gfdf": invalid URL escape "%gf" Test: Test_doaction FAIL sed -i 's|parse # #%%gfdf:|parse "# #%%gfdf":|' credentials/credential_test.go - License ok - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
