[Bug 1811266] Review Request: squeekboard - mobile keyboard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1811266

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Why not use
https://source.puri.sm/Librem5/squeekboard/-/archive/v1.9.0/squeekboard-v1.9.0.tar.bz2
as a source?

 - Validate the desktop file:

desktop-file-validate
%{buildroot}/%{_datadir}/applications/sm.puri.Squeekboard.desktop

 - Use the correct macro for /etc + be more specific:

%{_sysconfdir}/xdg/autostart/squeekboard.desktop

 - This should be executable:

squeekboard.x86_64: W: non-executable-in-bin /usr/bin/squeekboard-entry 644
squeekboard.x86_64: E: env-script-interpreter /usr/bin/squeekboard-entry
/usr/bin/env python3
squeekboard.x86_64: E: non-executable-script /usr/bin/squeekboard-entry 644
/usr/bin/env python3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux