[Bug 1811410] Re-Review Request: mkdocs - Python tool to create HTML documentation from markdown sources

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1811410



--- Comment #6 from Robin Lee <robinlee.sysu@xxxxxxxxx> ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01315964-mkdocs/mkdocs.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01315964-mkdocs/mkdocs-1.1-4.fc33.src.rpm

Changes:
- Drop explicit lunr requirement
- License specified to BSD and Tumbolia


(In reply to José Matos from comment #5)
> (In reply to Robin Lee from comment #4)
> > > These are not necessary. They are built automatically:
> > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> > > #_dependencies
> > 
> > These requirements are not automatically generated.
> 
> python3dist(lunr) is generated:
> 
> Requires
> --------
> mkdocs (rpmlib, GLIBC filtered):
>     /usr/bin/python3
>     bootswatch-fonts
>     fontawesome-fonts
>     fontawesome-fonts-web
>     google-roboto-slab-fonts
>     js-jquery1
>     js-jquery2
>     lato-fonts
>     python(abi)
>     python3.8dist(click)
>     python3.8dist(jinja2)
>     python3.8dist(livereload)
>     python3.8dist(lunr)
>     python3.8dist(markdown)
>     python3.8dist(pyyaml)
>     python3.8dist(setuptools)
>     python3.8dist(tornado)
>     python3dist(lunr)
>     python3dist(mdx-gh-links)
>     python3dist(nltk)
> 
> Notice as lunr appears above.
Fixed
> 
> 
> Regarding nltk I am curious why it is a dependency of mkdocs, it is not
> mentioned in the documentation and it does not show in the code.
Mkdocs requires an optional feature of lunr. And that option feature of lunr
requires nltk.
> 
> 
> BTW the License should be:
> 
> License: BSD and Tumbolia
> 
> The Tumbolia appears because of file mkdocs-1.1/mkdocs/utils/ghp_import.py
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux