https://bugzilla.redhat.com/show_bug.cgi?id=1814682 lsun@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lsun@xxxxxxxxxxxx | |) | --- Comment #13 from lsun@xxxxxxxxxxxx --- Thanks all for the comments! Below are the updated info (2.0.1) trying to solve these comments. Spec URL: https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.1/rshim.spec SRPM URL: https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.1/rshim-2.0.1-1.fc31.src.rpm koji build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=42727191 Below are the unsolved coverity warnings and explanations (based on Comment 12): Error: LOCK (CWE-667): [#def2] [lsun] Function rshim_write_delayed() has lock held outside by the caller. No need to unlock it on return. Error: LOCK (CWE-667): [#def3] [lsun] same. Error: MISSING_LOCK (CWE-667): [#def4] [lsun] This is the RSH_DEV_TYPE_TMFIFO case and is called from rshim_fifo_input()and rshim_fifo_output(). In both cases the ringlock are already held. Error: MISSING_LOCK (CWE-667): [#def5] [lsun] This one is called from the 'RSH_EVENT_ATTACH' handling, which already has the lock held when calling rshim_notify(bd, RSH_EVENT_ATTACH, 0). Error: MISSING_LOCK (CWE-667): [#def6] [lsun] same Error: SLEEP (CWE-367): [#def26] rshim_register(bd); [lsun] This one is called during device probe at early stage. The sleep purpose is to detect if any other driver has already attached to the same rshim device (since it could be attached from USB or PCIe via different host machine). The probing takes some time. The sleep here is ok. Error: MISSING_LOCK (CWE-667): [#def24] Error: MISSING_LOCK (CWE-667): [#def25] [lsun] same as [#def4 above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
